[XviD-devel] [BUG] Pink Frames (still lacks fix) ++

[Michael Militzer]

hey christoph,

I just had a look at your "bugfix": #ifdef BUGGY_BFRAMES? ;-)

What do we need to define now for a bframe build: BFRAMES, BFRAMES_DEC and
BUGGY_BFRAMES?

btw: why did you choose to remove the direct mode support? Seems you've
uploaded an outdated motion_comp.c, right?

As I said before: A major clean-up seems really necessary...

bye
Michael


----- Original Message -----
From: "Christoph Lampert" <chl@math.uni-bonn.de>
To: <xvid-devel@xvid.org>
Sent: Thursday, August 15, 2002 8:04 PM
Subject: Re: [XviD-devel] [BUG] Pink Frames (still lacks fix) ++


> On Thu, 15 Aug 2002, Dead2 wrote:
>
> > > > In my opinion the red and blue dc coefficients are saturated
> > > > by  a bug in  the bitstream  writer or  a MB  coding bug  (remainder
:
> > > > blue+red give pink :-) because pink MBs have an pink average color
and
> > > > the dc coefficient is the average chroma value of MB so...
> > >
> > > Nono, pink is not red+blue (that's RGB mode, forget it). Pink is the
> > > channel with "pink vs. green" (which is either U or V, I don't
> > > remember; the other is "blue vs. yellow". I hope.)
> >
> > Yep, this is the same problem as in the [XviD-devel] [BUG] thread.
>
> Bug found, bug squashed, problem fixed.
>
> It was motion compensation for chroma components.
> That tried to use image-based interpolation as soon as #BFRAMES was
> defined, but that only works if XVID_HALFPEL is on.
> The combination b-frames + non-halfpel is not possible, of course, but
> the combination BFRAMES + non-halfpel, say exactly when max_bframes=0
> or max_bframes=-1.
>
> So we'd better check for XVID_HALFPEL in motion_comp.c, even when
> BFRAMES is active.
>
> gruel
>
>
> --
> Christoph H. Lampert chl@math,uni-bonn,de | Diese Signature wurde maschi-
> Beringstr. 6, Raum 14 Tel. (0228) 73-2948 | nell erstellt und bedarf
> Sprechstunden: keine, aber meistens da    | keiner Unterschrift. AZ 27B-6
>
> _______________________________________________
> XviD-devel mailing list
> XviD-devel@xvid.org
> http://list.xvid.org/mailman/listinfo/xvid-devel
>