[XviD-devel] can someone explain me this...

Marco "elcabesa" Belli xvid-devel@xvid.org
Tue, 24 Dec 2002 15:37:09 +0100


inbside image.c file
there is this function:

image_deblock_rrv(IMAGE * img, int edged_width,
				const MACROBLOCK * mbs, int mb_width, int mb_height, int mb_stride,
				int block, int flags)

inside this you do
upsampling...

but why you use diffrent fucction to do it....

this is the code i cant understood..

if ((flags & XVID_DEC_DEBLOCKY))
	{
		.....
				xvid_HFilter_31_C(img->y + (j*block - 1)*edged_width + i*block,
								  img->y + (j*block + 0)*edged_width + i*block, nblocks);
		
.......
				vfilter_31(img->y + (j*block)*edged_width + i*block - 1,
						   img->y + (j*block)*edged_width + i*block + 0,
						   edged_width, nblocks);
........


	
				vfilter_31(img->u + (j*block)*edged_width2 + i*block - 1,
						   img->u + (j*block)*edged_width2 + i*block + 0,
						   edged_width2, nblocks);
				vfilter_31(img->v + (j*block)*edged_width2 + i*block - 1,
						   img->v + (j*block)*edged_width2 + i*block + 0,
						   edged_width2, nblocks);
.........
		
				hfilter_31(img->u + (j*block - 1)*edged_width2 + i*block,
						   img->u + (j*block + 0)*edged_width2 + i*block, nblocks);
				hfilter_31(img->v + (j*block - 1)*edged_width2 + i*block,
						   img->v + (j*block + 0)*edged_width2 + i*block, nblocks);



why one tines you use  xvid_HFilter_31_C?? and other times you use hfilter or 
vfilter?
is tihs a bug??

and why XVID_DEC_DEBLOCKY andXVID_DEC_DEBLOCKUV have the same code? 

#define XVID_DEC_DEBLOCKY		0x00000002	/* luma deblocking */
#define XVID_DEC_DEBLOCKUV		0x00000002	/* chroma deblocking */

thanks for you reply