[XviD-devel] Bframe bugfixes

[Edouard Gomez]

Christoph Lampert (chl@math.uni-bonn.de) wrote:
> On Mon, 22 Jul 2002, Christoph Lampert wrote:
> 
> > > 
> > > Done, same bugs, same frames.
> > 
> > I guess it was a range overflow of DCT coefficients,
> > caused by a too large quantizer for b-frames (namely 32). 
> > 
> > I commited a bugfix (just reenabled the range check in
> > lines 1019-1023 of encoder.c), so please test again!
> 
> Btw. the bugfix fixed some crashes but not all of the 
> wrong MBs, which may indeed be ME related...
> 

I've even  applied a second patch  for another quant  range check.  As
you said, there is still wrong MBs  , and as you supose, they might be
ME related.

Commit the patch if you consider it useful.

################## Patch beginning ####################
Index: encoder.c
===================================================================
RCS file: /xvid/xvidcore/src/encoder.c,v
retrieving revision 1.63
diff -u -r1.63 encoder.c
--- encoder.c	22 Jul 2002 18:03:47 -0000	1.63
+++ encoder.c	22 Jul 2002 19:08:23 -0000
@@ -853,12 +853,12 @@
 		else
 			pEnc->current->quant = pFrame->quant;
 
-/*		if (pEnc->current->quant < 1)
+		if (pEnc->current->quant < 1)
 			pEnc->current->quant = 1;
 
 		if (pEnc->current->quant > 31)
 			pEnc->current->quant = 31;
-*/
+
 		pEnc->current->global_flags = pFrame->general;
 		pEnc->current->motion_flags = pFrame->motion;
 
####################### Patch EOF ######################

-- 
Edouard Gomez