[XviD-devel] bframes+2pass working

Dirk Knop xvid-devel@xvid.org
Fri, 29 Nov 2002 12:35:09 +0100


Thanks for the nice work pete, but

peter ross wrote:

> foxers code needs some refinement; specifically, vfw should NOT ask
> xvidcore to generate DELAY (0x7f) or PAD (divx not-coded-vops) frames.
> vfw should only request the desired coding type (i/p/b) for the
> current frame. 

agreed :)

> to get arround foxers code (gotta meet thos foxer chap someday...),
> ive modified codec.c such that these frames are not requested:
>
>        while (codec_2pass_get_quant(codec, &frame) == 2) ; 

shouldn't this be "while (codec_2pass_get_quant(codec, &frame) <= 2) ;" 
(respective the other way around [>2], i didn't look at the code snippet 
wher this belongs) because we have to request i, p and bframes?

Anyways, thanks a million for correcting the code :)

Cheers,
Koepi