[XviD-devel] [BUG] XVID_CSP_RGB24 + XVID_CSP_VFLIP

[suxen_drol]

On Tue, 14 Jan 2003 00:36:38 +0100 Edouard Gomez <ed.gomez@free.fr> wrote:

> I've been updating the transcode module for dev-api-3 support yesterday
> and today. And i found what seems to be a bug in rgb24+vflip.
> 
> Tell me if i'm wrong but, when using vflip you're expecting to receive:
>  frame->image = frame_data;
>  frame->stride= frame_width*3; /* Simple case where rgb data is not  padded */
> 
>  and of course you must use RGB24+VFLIP during encoder creation.
> 
> With these settings i'm getting garbage image.
> 
> But if i use a nasty workaround like this:
> 
>  frame->image = frame_data + frame_width*(frame_height-1)*3;
>  frame->stride= -frame_width*3;
> 
>  and not using vflip

hmm, that's essentially what XVID_CSP_VFLIP does.

> 
> then my image is fliped just like i want.
> 
> Is this normal or is it a bug ?

the flipping code is generic, so in theory if it fails for rgb24 it
should fail for all colorspaces. i shall look into it.

btw, is mmx activated?

-- pete