[XviD-devel] [CVS commit] dev-api-4: ANSI C style comments

Edouard Gomez ed.gomez at free.fr
Mon Jun 9 19:01:18 CEST 2003


Hello,

I had some time  to work on XviD this week end.  Thus i decided to start
achieving the same goals as  for XviD 0.9.x tree... clean code, compiles
with even ANSI C compilers etc etc etc

I decided to make it compile with ANSI C compiler.

Just a  remark on CodingStyle, when you  disable code, try to  use #if 0
#endif blocks, using comments is really not the right way to do it.

1/ we can't find disabled code easily
2/ most  of  the  time,  this  is creating  a  "comment  into  comment"
   situation, many old ANSI C compilers do not like this at all. 

Here's the changelog:

2003-06-09 GMT	Edouard Gomez <ed.gomez at free.fr>	patch-62

    Summary:
      ANSI C comments.
    Revision:
      xvidcore--devapi4--1.0--patch-62

    Turned all // ISO C99 comments into ISO C89 (aka ANSI C) coment style.
    
    Now XviD compiles fine with gcc 3.x -std=iso89 option. This should help
    those people who want to get XviD working on DSPs or any other exotic
    hardware. This type of exotic hardware is usually shipped with a very
    spartiate ANSI C compiler.
    
    NB: Big patch that breaks all kind of cherry picking merges.

    modified files:
     examples/odivx_enc_dec.c examples/xvid_bench.c
     src/bitstream/bitstream.c src/bitstream/mbcoding.c
     src/bitstream/mbcoding.h src/bitstream/zigzag.h src/dct/fdct.c
     src/dct/idct.c src/dct/simple_idct.c src/decoder.c
     src/decoder.h src/encoder.c src/encoder.h src/global.h
     src/image/colorspace.c src/image/font.c src/image/image.c
     src/image/interpolate8x8.c src/image/interpolate8x8.h
     src/image/reduced.c src/motion/motion.h
     src/motion/motion_comp.c src/motion/motion_est.c
     src/motion/motion_est.h src/motion/sad.c
     src/plugins/plugin_2pass2.c src/prediction/mbprediction.c
     src/prediction/mbprediction.h src/quant/adapt_quant.c
     src/quant/adapt_quant.h src/quant/quant_h263.c
     src/quant/quant_h263.h src/quant/quant_mpeg4.c
     src/quant/quant_mpeg4.h src/utils/mbtransquant.c
     src/utils/mem_transfer.c src/utils/timer.c src/xvid.c
     vfw/src/2pass.c vfw/src/codec.c vfw/src/codec.h
     vfw/src/config.c vfw/src/config.h vfw/src/driverproc.c

-- 
Edouard Gomez


More information about the XviD-devel mailing list