[XviD-devel] New Trellis Quant

[Christoph Lampert]

On Tue, 13 May 2003, Radek Czyz wrote:
> >         /* quality 6 */
> >         XVID_VOP_DYNAMIC_BFRAMES | XVID_VOP_HALFPEL |
> >         XVID_VOP_INTER4V | XVID_VOP_MODEDECISION_BITS |
> >         XVID_VOP_HQACPRED
> 
> Allrighty, I found the problem: even if you're doing BITS refinement,
> you should still do sad-based refinement! 

Why? 

> The code will work without
> it, but PSNR _must_ decrease... 

Why? 

> This is true for 16x16 refinement - 8x8 sad-refinement is
> automatically deactivated if bits-refinement is on (it's just faster
> this way).
> 
> [...] 
>
> I reviewed the code and found some minor bugs here and there. I'll
> commit the changes soon (but without R-D yet) - and Ed will kill me,
> because I will have committed it to dev-api-3, and the number of
> changes is big....

Nooo, not to dev-api-3... this will be a complete desaster, to add new
features to dev-api-3 _and_ dev-api-4 at the same time. 

gruel