[XviD-devel] [CVS commit] devapi4 -- ME basing its search on wrong data

[Edouard Gomez]

In our  series "valgrind is our  friend", another possible  bug. I'm not
very  confortable  with ME  stuff,  but i  think  that  when using  QPel
refinement in  SearchP, iMinSAD2 should be  initialized, otherwise, some
tests are performed in  ChecCandidate16_qpel with unitialized data or at
least not deterministic data.

if (Data->qpel) {
  get_range(...);
  Data->qpel_precision = 1;
  if (quarter pel refinement 16x16)
    *Data->iMinSAD2 =  256 *  4096;
    do_refinement_fast_or_normal()
  }
}

This way first check candidate will overwrite with a valid value.

-- 
Edouard Gomez