[XviD-devel] [CVS commits] devapi4 -- Mass commit

Michael Militzer michael at xvid.org
Wed Oct 29 00:50:54 CET 2003


Quoting Edouard Gomez <ed.gomez at free.fr>:

> The static motion code is probably wrong in the else statement.
> 
>     if(MotionFlags & XVID_ME_DETECT_STATIC_MOTION) {
>         if(x > 0 && y > 0 && x < pParam->mb_width) {
>           ... something valid from a memory access point of view
>         } else {
>           do stuff with (x - 1) MBs
>           do stuff with (y - 1) MBs
>         }
>     }
> 
> First, due to the for loop surrounding this piece of code, we know
> 0<=x<mb_width.
> 
> The problem is probably caused when the else block is evaluated for MBs
> with x=0 or y=0. Michael, can you have a look at this piece of code ?
> Perhaps another bug related to your cleanup before commit ?

argh, this else statement shouldn't belong to the if(x>0 ...) check at all.
I've just uploaded a fix for this...

bye,
Michael


More information about the XviD-devel mailing list