[XviD-devel] motion_est.c splitted and cleaned - what do you think?

[Edouard Gomez]

Radek Czyz (syskin at ihug.com.au) wrote:
> blablabla

Fine for me, i have a patchset ready that fixes things you missed. I'll
commit that toonight, so please don't commit changes to ME.

Here is a sum up of the changes from a RCS point of view:

* removed files
 
    src/motion/motion_est.c
    src/motion/motion_est.h
    src/motion/smp_motion_est.c
    src/motion/smp_motion_est.h
 
* added files
 
    src/motion/estimation.h
    src/motion/estimation_bvop.c
    src/motion/estimation_common.c
    src/motion/estimation_gmc.c
    src/motion/estimation_pvop.c
    src/motion/estimation_rd_based.c
    src/motion/motion_inlines.h
    src/motion/vop_type_decision.c
 
* modified files
 
    build/generic/sources.inc
    build/win32/libxvidcore.dsp
    src/bitstream/mbcoding.h
    src/motion/gmc.c
    src/motion/gmc.h
    src/motion/motion.h
    src/motion/motion_comp.c
    src/motion/sad.c
    src/motion/sad.h
    src/prediction/mbprediction.c
    src/prediction/mbprediction.h
    src/utils/mbfunctions.h

PS: the patchset removes some code warnings as well in fast mode
decision (sad may be used unitialized when blocks are skipped, and cbp
may be used unitialized in certain cases, i added sad = 0 before goto
early_out and cbp = 63 in the declaration block -- they should be safe)
and a bug with a wrong if statement (a && b || c) instead of
(a && (b || c))

--
Edouard Gomez