[XviD-devel] Alignement problem

[Skal]

	Bonjour Alexandre,

On Mon, 2005-04-11 at 15:14, Alexandre Ganea wrote:
> Hi all,
> 
> I don't know if this is already known, but I found a small problem in mem_transfer.cpp, in the function transfer8x8_copy_c(). The code assumes that the src and dst buffers are aligned on a 4-byte boundary and this is not the case for src. This code works well on Intel cpus, but might not produce the expected results on *any* RISC cpu imho. (tested only on ARM) As it is supposed to be generic version of this function, I would replace it by a simple loop working on bytes instead:
> 
> for ( y = 0; y < 8; ++y ){
> 
>     uint8_t * d = dst + y * stride;
> 
> const uint8_t * s = src + y * stride;
> 
> for ( x = 0; x < 8; ++x )
> 
> {
> 
> *d++ = *s++;
> 
> }
> 
> }

	You're perfectly right! Could someone commit the change?
	I'd like to, but don't know what is the current tag/revision/whatever for that.

	bye!
Skal