[XviD-devel] vbv patch

[Michael Militzer]

Hi,

since vbv compliance and the DivX profile are an important new feature in
XviD 1.1, I think the patch should be applied and another beta should be 
released. After all, the current implementation of the DXN profiles in 1.1
beta1 is wrong, so your patch is imho more a bugfix than a new feature.

bye,
Michael


Quoting peter ross <suxen_drol at hotmail.com>:

> gday,
> 
> divxnetworks has advised the our current dxn profiles do not conform to 
> their latest
> certification standard, and should be modificied to incorporate the 
> following constraints:
> 
> * 4mv is disabled for the handheld profile
> * 1:1 picture aspect only
> * disable bframes if interlacing is enabled
> * force maximum of 1 consecutive bvop for the portable and ht profiles, and 
> 2 bvops for the hd profile
> * always write divx 5 userdata string to bitstream "DivX503b1393(p)"
> * force packed bitstream option
> * update vbv params
> 
> i have assembled a patch, that adds an additional "strict conformance to dxn
> 
> profile
> standard" checkbox. this is checked by default, but can be unchecked by 
> advanced
> users who wish to experiment. since the v1.1 release is impending and 
> feature
> frozen, i have attached the patch below for review. perhaps we need another 
> beta,
> to give users a chance to test the "new" profiles with hardware players?
> 
> christoph: dxn now uses a "max bits over 1sec constraint" instead of the 
> 3sec constraint.
> this needs to be changed within xvidcore. currently, vfw multiplies the 
> 1second
> constraint by 3 before passing it to xvidcore.
> 
> FULL CHANGE LOG:
> 
> xvidcore
> ========
> added XVID_GLOBAL_DIVX5_USERDATA global flag
> removed the bvop delay warning text. this confuses joe user.
> 	"warning: nothing to output"
> 	"bframe decoder lag"
> minor changed to closed gop image_printf statement:
> 	s/"DX50 BVOP->PVOP"/"CLOSED GOP BVOP->PVOP"
> additional comments for low_delay_default mode within decoder_decode()
> divx userdata string: s/DivX999b000/DivX503b1393
>   this has been suggested by dxn for improved hardware compatibility
>   [nb: i dont have a hardware player to confirm this]
> vbv_peakrate constraint is ignored if <= 0
> 
> vfw frontend
> ============
> "strict conformance to DXN profile standard" checkbox:
>   force 1:1 picture aspect ratio
>   disable bframes if interlacing is enabled
>   force maximum of 1 consecutive bvops for the portable and ht profiles, 2 
> bvops for the hd profile
>   always write divx 5 userdata string to bitstream
>   force packed bitstream option
>   updated dxn vbv parameters
> 
> added PROFILE_4MV flag. 4mv is now disabled for the dxn handheld profile.
> moved PROFILE_AS/PROFILE_ARTS/PROFILE_S to config.c
> profile[].max_bitrate now measured in bit/sec (not kbps)
> 
> profile->level box: widgets are now greyed-out if they are not used.
> increase vertical size of profile drop down list.
> 
> about box button: s/Dismiss/OK
> 
> cheers,
> -- pete
> 
>