[XviD-devel] MMX improvements

[Guillaume POIRIER]

Hi,

On 7/12/05, carlo.bramix <carlo.bramix at libero.it> wrote:
> Ok, after some hours of work and study (I had to understand how CVS works) I was able to make the patch with TortoiseCVS.

It's unfortunately not the way it should be; If you have a closer look
at your patch, it mostly consists in deleting the whole file to
replace it with your implementation, which *could* be fine if you had
found a revolutionary way to schedule the SIMD code, but I doubt it.
All the more since your patch also changes the header, which has
nothing to do with your MMX optimizations.

This makes the reviewing task of the maintainers a little more difficult.

I don't know how tortoiseCVS works, but you should try to find an
option that discards white space changes to make this patch more
readable.

Could you maybe resend a clean patch?

Regards,
Guillaume
-- 
A lie gets halfway around the world before the truth has a chance to
get its pants on.
 -- Winston Churchill