[XviD-devel] [PATCH] Make xvid_decraw tga output usable on big endian hosts

[Edouard Gomez]

Selon Paul Kurucz <ptk9417 at ritvax.isc.rit.edu>:
> >  		for (i=0; i<width*height*BPP;i+=BPP) {
>
> "width" and "heigth" aren't defined.  It should be XDIM*YDIM.  No?

Hmmm how could that slip into my xvidcore tree, i was reusing this function in
another project of mine and had to rename width/height which were arguments.

I'll resubmit a patch then.

>
> >  			if (BPP == 1) {
> .....
> .....
> >  			} else if (BPP == 2) {
> > -				fputc(image+i+1, f);
> > -				fputc(image+i+0, f);
> > +				fputc(*(image+i+1), f);
> > +				fputc(*(image+i+0), f);
>
> 	How about:
> 		fputc(image[i+1], f);
> 		fputc(image[i+0], f);

Well i'm not going to enter into notation wars, one or the other are fine adn
equivalent in this case, so going for the less effort i'll stay with the
pointer notation :-)

--
Edouard Gomez