[XviD-devel] [Fwd: Data partitioning for encoder]

[Skal]

	Hi Sigdrak and all,

On Sun, 2005-05-15 at 14:36, sigdrak wrote:
> Hello Skal,
> 
> Skal wrote:
> > 	i've reviewed it, and it looks ok at first sight.
> > 	*But* it (the 2nd version) also contains cosmetics
> > 	changes i don't feel like committing right now in
> 
> I agree, though I didn't like much how it was written: a pain to track 
> what needs being deallocated for each error. Anyway, you can just create 
> a branch tag and merge back in eventually.

	i've applied your code for error handling. Definitely cleaner.
> 
> > 	the middle of a beta2. Moreover i've got some
> 
> This is understandable. Given the API changes, that would only bring 
> troubles.
> 

	Not only API: your new log2bin() func taken from ffmpeg ...
	wasn't equivalent to the current one. Anyway, i've committed
	a faster version (not that it's critical func, but still...).
	Xvid_bench.c has a bench for that, now.

	Also, for you and Angela Belda (working on resync markers):
	i've added your functions BitstreamWriteEndOfSequence(),
	BitstreamWriteGroupOfVopHeader(), and write_video_packet_header() 
	at the end of bitstream.c, since they looked ok. 
	They are *unused* as of now, but now you have them handy...

	(@Sigdrak: your patch did declare BitStreamWriteStartOfVideoPacket(), 
	but the implementation was missing)

	Please check,

-Skal