[XviD-devel] Unsupported opcode into "quantize_mpeg_mmx.asm"

[skal]

   Hi Carlo and all,

> Message du 21/09/06 22:33
> De : "carlo.bramix" <carlo.bramix at libero.it>
> A : "xvid-devel" <xvid-devel at xvid.org>
> Copie à : 
> Objet : [XviD-devel] Unsupported opcode into "quantize_mpeg_mmx.asm"

> the latest quantize_mpeg_mmx.asm crashes on my PC.
> The cause is the "cmovg" opcode used into quant_mpeg_intra_mmx() function.
> I suggest the following change, which should be as fast as the P2 opcode (perhaps a bit faster!) and also fixed my problem.

   Thanks! looks ok to me... (Syskin?)

> Small note: if you look into the changed code, you will see that the sign-extend of EAX into EDX has been done with a copy-shift instead of CDQ. I made it because I think it's better since these two opcodes can be paired safely to others, while CDQ cannot be paired to anything.

   well, the 'idiv' hits hard anyway; and there's also a long
   dependancy chain around ecx...

   bye!
Skal