[XviD-devel] Questions / Bug fixes / Patches

[Michael Militzer]

Hi,

I don't agree. According to my understanding, the allowed value range for
frame_drop_ratio is [0, 100] in xvid API (see xvid.h). Negative values are
not legal and are clipped to zero in l. 264 of encoder.c. Therefore, your
proposed patch will have no effect.

If we want to disable the creation of N_VOPs for frame_drop_ratio=0 we
should apply the patch that was earlier proposed by Carl Eric Codere.

Best regards,
Michael


Quoting Marcin Jaworski <indrid at o2.pl>:

> Hello,
>
> The API uses "-1" to disable N-VOPs, but the VfW GUI (at least in the
> vanilla source code) doesn't allow entering negative values into the
> Frame Drop Ratio field. It can be "fixed" with this simple patch:
>
> http://pastebin.com/pHMf3gri
>
> N-VOPs seem to confuse some standalone players. How about committing
> this patch? It's just a simple GUI enhancement ;-)
>
> Best regards,
> Marcin Jaworski
> _______________________________________________
> Xvid-devel mailing list
> Xvid-devel at xvid.org
> http://list.xvid.org/mailman/listinfo/xvid-devel
>
>