[XviD-devel] no-exec-stack on elf32

Michael Militzer michael at xvid.org
Fri Feb 25 12:35:41 CET 2011


Hi,

actually, I don't experience this problem (with latest yasm). For 32-bit
target, the configure script sets "elf" as the -f parameter and the check
in nasm.inc consequently sets no-exec stack as expected.

So I guess it's nasm (and version)-specific whether "elf" will be mapped
to "elf32" or not. I'd say we should therefore better have a check for
both "elf" and "elf32" to be safe...

Thanks for your hint.

Regards,
Michael


Quoting Fabian Greffrath <fabian at greffrath.com>:

> Dear xvid devs,
>
> the current Xvid source code still produces a shared library with an
> executable stack when compiled with nasm on a 32-bit system. The
> reason is that in the current implementation the output format is
> checked for "elf" and "elf64", whereas the 32-bit variant is called
> "elf32". The patch found here fixes this:
> <http://git.debian.org/?p=pkg-multimedia/xvidcore.git;a=blob;f=debian/patches/no-exec-stack-elf32.patch>
>
> "elf" is, however, a valid output format for nasm when used with the
> -f parameter and serves as a shortcut for "elf32". so maybe it makes
> sense to add a separate check for "elf32" instead of replacing the
> check for "elf", but that's up to you. ;)
>
>   - Fabian
> _______________________________________________
> Xvid-devel mailing list
> Xvid-devel at xvid.org
> http://list.xvid.org/mailman/listinfo/xvid-devel
>
>





More information about the Xvid-devel mailing list