[Xvid-devel] Patch for XVID MPEG-4 DirectShow/MediaFoundation filter

Jerker Bäck jerker.back at gmail.com
Mon Jun 13 17:58:59 CEST 2011


Hi Michael,

Very well, of course one could use the _T() or TEXT() macro for every string
to enable the UNICODE define functionality. Hardcore ATL/WTL/MFC'ers use
this extensively. However, this often goes bad against code that are not
aware of such functionality (e.g. UNIX code). In the Xvid code there is
actually an example of the need to explicit use ASCII characters (config.c
145). All COM code needs wide strings. There is little point in using ANSI
strings in Shell/COM source since they must all be translated and eventually
use the wide functions anyway. 

So if you prefer to use a mix of ASCII, wide and UNICODE-aware strings, then
my patch will not do. I just think it would be clearer, more safe and more
consistent to decide the type at code level and not let the
compiler/pre-processor decide.

Cheers
Jerker




More information about the Xvid-devel mailing list