[Xvid-devel] make clean may trigger configure run

Fabian Greffrath fabian at greffrath.com
Thu May 19 18:55:19 CEST 2011


Hi,

currently, if one runs "make clean" (or "make distclean" or "make 
mrproper") in the build/generic directory in an already distclean'ed 
source, then this will trigger a configure run, which is IMHO 
completely useless!

The reason for this behaviour is that build/generic/Makefile in line 
44 unconditionally includes platform.inc, which has been properly 
removed by the distclean rule before. The missing platform.inc file 
then triggers the call to configure via its own rule in line 158.

However, since the platform.inc file is completely irrelevant for the 
clean rules, please consider the attached patch that conditionally 
includes platform.inc in the Makefile only if it is not called with 
one of the clean rules.

Best Regards,
Fabian

--

--- Debian.orig/xvidcore/build/generic/Makefile
+++ Debian/xvidcore/build/generic/Makefile
@@ -41,7 +41,9 @@
 
##############################################################################

  include sources.inc
+ifeq ($(findstring $(MAKECMDGOALS), clean distclean mrproper),)
  include platform.inc
+endif

  RM = rm -rf



More information about the Xvid-devel mailing list