[Xvid-devel] [PATCH] fix xvid_plg_data_t fields documentation
Michael Militzer
michael at xvid.org
Wed May 29 08:00:10 CEST 2019
Hi,
you are right. bquant_ratio / bquant_offset are "out" parameters in
xvid_plg_data_t and are "in" only within the context of
xvid_enc_create_t.
Patch applied, thanks.
Best regards,
Michael
Quoting delthas <delthas at dille.cc>:
> Hey,
>
> Just a very small patch to the documentation in xvid.h, namely the
> fields bquant_ratio and bquant_offset of struct xvid_plg_data_t which
> are listed as "[in]" (written to by the plugin) but should be "[out]"
> (read by the plugin).
>
> I haven't updated the Changelog since the change is insignificant.
>
> Diff is below.
>
> Thanks,
> delthas
>
>
> Index: xvidcore/src/xvid.h
> ===================================================================
> --- xvidcore/src/xvid.h (revision 2174)
> +++ xvidcore/src/xvid.h (working copy)
> @@ -460,8 +460,8 @@
> int sse_v; /* [out] V plane's sse */
> /* End of duplicated data, kept only for binary compatibility */
>
> - int bquant_ratio; /* [in] */
> - int bquant_offset; /* [in] */
> + int bquant_ratio; /* [out] */
> + int bquant_offset; /* [out] */
>
> xvid_enc_stats_t stats; /* [out] frame statistics */
> } xvid_plg_data_t;
> _______________________________________________
> Xvid-devel mailing list
> Xvid-devel at xvid.org
> http://list.xvid.org/mailman/listinfo/xvid-devel
>
>
More information about the Xvid-devel
mailing list