[XviD-devel] [CVS commits] head -- Stable merge + decoder optims

[Edouard Gomez]

Michael Militzer (michael at xvid.org) wrote:
> Hi,
> 
> I suppose the 64 bit change affects timecodes (as these are the only ones
> where we use 64 bit variables in the code (apart from 2pass code) afaik).
> I admit I haven't looked at the actual code changes yet but I remember
> there was some reason for switching to 64 bit originally. Ok, I again 
> assume you only _not_ use 64 bit timecodes for the calculation of B-direct
> vectors (and this may be ok), but I'd like to have Christoph a look at 
> this because I believe he originally wrote the timecode support and also
> originally introduced the 64 bit arithmetics. So he should know why he
> initially did this ;-))

Here is what i remember and what i analysed:
- DECODER struct holds 32 bit values for bp and pp
- in decoder.c, i dunno why, but a - operation is supposed to
  give 64bit
- 64bit values were introduced in *encoder* because there was
  no safe way to do bp/pp using 32bits, and 64bit were just so
  easy to use in order to solve the problem.

As i see it, 64bit introduced by christoph were in encoder.c,
not in decoder.c. And afaict, 64bit aren't needed to
interpolate vectors.

Of course, christoph is the one who can confirm this. Waiting
for his answer.

-- 
Edouard Gomez