[XviD-devel] MMX improvements
carlo.bramix
carlo.bramix at libero.it
Tue Jul 12 20:13:59 CEST 2005
Hello,
I found the cause of the "problem".
My sources have a 0Dh 0Ah at the end of each line, while the sources into the CVS repository have only 0Ah.
But I started from these sources:
http://downloads.xvid.org/downloads/xvid_latest.tar.gz
and they are already in MS-DOS format!
I will try to change my modified source to Unix format before doing the patch file.
Sincerely,
Carlo Bramini.
---------- Initial Header -----------
>From : xvid-devel-bounces at xvid.org
To : xvid-devel at xvid.org
Cc :
Date : Tue, 12 Jul 2005 14:58:16 +0200
Subject : Re: [XviD-devel] MMX improvements
> Hi,
>
> On 7/12/05, carlo.bramix <carlo.bramix at libero.it> wrote:
> > Ok, after some hours of work and study (I had to understand how CVS works) I was able to make the patch with TortoiseCVS.
>
> It's unfortunately not the way it should be; If you have a closer look
> at your patch, it mostly consists in deleting the whole file to
> replace it with your implementation, which *could* be fine if you had
> found a revolutionary way to schedule the SIMD code, but I doubt it.
> All the more since your patch also changes the header, which has
> nothing to do with your MMX optimizations.
>
> This makes the reviewing task of the maintainers a little more difficult.
>
> I don't know how tortoiseCVS works, but you should try to find an
> option that discards white space changes to make this patch more
> readable.
>
> Could you maybe resend a clean patch?
>
> Regards,
> Guillaume
> --
> A lie gets halfway around the world before the truth has a chance to
> get its pants on.
> -- Winston Churchill
> _______________________________________________
> XviD-devel mailing list
> XviD-devel at xvid.org
> http://list.xvid.org/mailman/listinfo/xvid-devel
>
____________________________________________________________
Navighi a 4 MEGA e i primi 3 mesi sono GRATIS.
Scegli Libero Adsl Flat senza limiti su http://www.libero.it
More information about the XviD-devel
mailing list