[XviD-devel] PATCH: Integer division by 0 on seek

[Michael Militzer]

Hello Haruhiko,

thank you for your patch. Unfortunately, the list strips attachments for
security reasons. So could you please paste your patch into the body of
your mail and repost or alternatively upload your patch somewhere and
provide a link?

Thank you,
Michael


Quoting Haruhiko Yamagata <h.yamagata at nifty.com>:

> Hi all,
>
> I'm here to say thank you and to submit a very small patch.
> I'm one of the developers of ffdshow-tryouts. We recently copied
> xvidcore into our svn.
> Thank you very much for your great product and letting us use/depend on.
>
> We found a very rare crash (Integer division by 0) on seek when
> xvidcore.dll is used in ffdshow.
> I think this crash is not ffdshow specific.
> The attached patch fixes the crash.
>
> I hesitate to submit the sample (very large). I'm not sure if the
> sample is broken or not.
> Even with the sample, the crash occurs only once per some hundreds of
> seeks for me
> (but more frequently for _xxl, a member of our project).
> I hope you can understand what the patch does, even if you cannot
> reproduce the crash.
>
> Another stuff, I have ported colorspace_rgb_mmx.asm to win64-sse2. I'll
> submit when ready.
>
> Best regards,
>  Haruhiko Yamagata