[XviD-devel] InstallShenanigan

[Kerewin]

Hi,

Yeah, well I have used Cygwin and Minging too but I want a fancy IDE
automake and not too much typing. I want to do the verb noun thing with a
mouse not my finger tips...

I suppose I will have to write an InstallShield script or whatever to get
access to codecer control type panels... 

One of the little tweaks I have made is to add a version resource to the
codec and decoder so programs show (PM),www.xvid.org in the vender field...

This is an easy tweak that also helps to visually show that it is what I am
building at the moment in the likes of gspot.exe.

Something like this although I am surprised U.K. component is coming
through... I selected language neutral.

////////////////////////////////////////////////////////////////////////////
/
// English (U.K.) resources

#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_ENG)
#ifdef _WIN32
LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_UK
#pragma code_page(1252)
#endif //_WIN32

////////////////////////////////////////////////////////////////////////////
/
//
// Version
//

VS_VERSION_INFO VERSIONINFO
 FILEVERSION 1,1,1,0
 PRODUCTVERSION 1,1,1,0
 FILEFLAGSMASK 0x1fL
#ifdef _DEBUG
 FILEFLAGS 0x9L
#else
 FILEFLAGS 0x8L
#endif
 FILEOS 0x4L
 FILETYPE 0x0L
 FILESUBTYPE 0x0L
BEGIN
    BLOCK "StringFileInfo"
    BEGIN
        BLOCK "000004b0"
        BEGIN
            VALUE "Comments", "Derivative xvid.org Koepi release build of
30Dec05"
            VALUE "CompanyName", "(PM), www.xvid.org"
            VALUE "FileDescription", "GUI for XviDCore DLL"
            VALUE "FileVersion", "1, 1, 1, 0"
            VALUE "InternalName", "xvidvfw.dll"
            VALUE "LegalCopyright", "GPL"
            VALUE "OriginalFilename", "xvidvfw.dll"
            VALUE "PrivateBuild", "Compiled with VC2K5.NET (unmanaged)"
            VALUE "ProductName", "XviD MPEG-4 Codec (Video For Windows)"
            VALUE "ProductVersion", "1, 1, 1, 0"
        END
    END
    BLOCK "VarFileInfo"
    BEGIN
        VALUE "Translation", 0x0, 1200
    END
END

#endif    // English (U.K.) resources
////////////////////////////////////////////////////////////////////////////
/


Another little thing, xvid_bench, line 776 or so:
//ilh Dst2 isn't used!!
//DECLARE_ALIGNED_MATRIX(Dst2,8, 8, int16_t, 16);


plugin_dump.c:-
xvidcore-1.1.0\src\plugins\plugin_2pass2.c(497) : error C2520: conversion
from unsigned __int64 to double not implemented, use signed __int64

There are more of these, and after all they are compile time errors. Is
there anything wrong with signed 64bit ints?

xvidcore-1.1.0\src\bitstream\bitstream.c(1407) : warning C4244: '=' :
conversion from '__int64 ' to 'int ', possible loss of data

void
BitstreamWriteGroupOfVopHeader(Bitstream * const bs,
                               const MBParam * pParam,
                               uint32_t is_closed_gov)
{
  int64_t time = (pParam->m_stamp + (pParam->fbase/2)) / pParam->fbase;
  int hours, minutes, seconds;

  /* compute time_code */
!  seconds = time % 60; time /= 60;
!  minutes = time % 60; time /= 60;
!  hours = time % 24; /* don't overflow */

<snip>

Why not change to:

  //ilh int is enough, only interested in <18 bits
  int time =(int) (pParam->m_stamp + (pParam->fbase/2)) / pParam->fbase;

This gets rid of three warnings and reduces about 5(?) 64bit ops to 5 32bit
ops.

Oh well, this my first contribution and it really is not too impressive.

Kerewin :(


<snipified>

Originally:-

That's a nice resume.

I'm no authoritative figure, nor even a contributor (yet), but I have
been following XviD and have actively tested it and given feedback to
some of the developers on IRC in the past and it is my view that any
good patches will be more than welcome and will be reviewed in good
time. I don't think there's any need to ask if you can join the team,
just do what you want to do and submit a patch to this mailing list.

Also, a likely reason for the MSVC projects being so awkward to use
could be that many people develop in non-Windows and even those who use
Windows are not limited to MS tools. The likes of MinGW and Cygwin make
life easier (possibly ;)) for projects such as XviD.

So, welcome. :)

> Kerewin.

Rob

_______________________________________________
XviD-devel mailing list
XviD-devel at xvid.org
http://list.xvid.org/mailman/listinfo/xvid-devel